Optimize to_bytes() using table lookup#127
Open
fereidani wants to merge 2 commits intocontain-rs:masterfrom
Open
Optimize to_bytes() using table lookup#127fereidani wants to merge 2 commits intocontain-rs:masterfrom
to_bytes() using table lookup#127fereidani wants to merge 2 commits intocontain-rs:masterfrom
Conversation
Contributor
|
Thanks! Will benchmark and merge |
Contributor
|
My benches show an improvement from 37 us to 25 us |
Contributor
|
How do I run these CI checks? Could you re-push or re-open? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Great project! I just made these changes to optimize
to_bytes(), you can use the added benchmark to check the performance.I only tested this on my AMD x64 6650u.
It would be a good idea to test it on other platforms before merging.
I also tested directly using
reverse_bitslike:and it performed worst than lookup table solution.